metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From JonZeolla <...@git.apache.org>
Subject [GitHub] metron pull request #800: METRON-1251: Typo and formatting fixes for metron-...
Date Tue, 17 Oct 2017 16:45:03 GMT
GitHub user JonZeolla reopened a pull request:

    https://github.com/apache/metron/pull/800

    METRON-1251: Typo and formatting fixes for metron-rest README

    ## Contributor Comments
    This fix properly format the github md in addition to the site-book docs (previously the
github formatting was broken).  It also fixes a typo regarding `/etc/sysconfig/metron`.
    
    ## Pull Request Checklist
    
    Thank you for submitting a contribution to Apache Metron.  
    Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235)
for the complete guide to follow for contributions.  
    Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview)
for complete smoke testing guides.  
    
    
    In order to streamline the review of the contribution we ask you follow these guidelines
and ask you to double check the following:
    
    ### For all changes:
    - [X] Is there a JIRA ticket associated with this PR? If not one needs to be created at
[Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).

    - [X] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are
trying to resolve? Pay particular attention to the hyphen "-" character.
    - [X] Has your PR been rebased against the latest commit within the target branch (typically
master)?
    
    ### For documentation related changes:
    - [X] Have you ensured that format looks appropriate for the output in which it is rendered
by building and verifying the site-book? If not then run the following commands and the verify
changes via `site-book/target/site/index.html`:
    
      ```
      cd site-book
      mvn site
      ```
    
    #### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible.
    It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal
repository such that your branches are built there before submitting a pull request.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/JonZeolla/metron METRON-1251

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/metron/pull/800.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #800
    
----
commit 6dc567456ef740420fb79c1f707649b3c295b01e
Author: Jon Zeolla <zeolla@gmail.com>
Date:   2017-10-16T19:04:28Z

    METRON-1251 - Typo and formatting fixes for metron-rest README

commit 46259e03a8d090389253d9024f3f6d14df77111e
Author: Jon Zeolla <zeolla@gmail.com>
Date:   2017-10-16T19:10:35Z

    Fix minor typo

----


---

Mime
View raw message