metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ottobackwards <...@git.apache.org>
Subject [GitHub] metron pull request #823: METRON-1286 Add MIN & MAX Stellar functions
Date Thu, 02 Nov 2017 13:34:19 GMT
Github user ottobackwards commented on a diff in the pull request:

    https://github.com/apache/metron/pull/823#discussion_r148532449
  
    --- Diff: metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/functions/OrdinalFunctions.java
---
    @@ -0,0 +1,75 @@
    +package org.apache.metron.stellar.dsl.functions;
    +
    +import org.apache.metron.stellar.dsl.BaseStellarFunction;
    +import org.apache.metron.stellar.dsl.Stellar;
    +
    +import java.util.Collections;
    +import java.util.List;
    +import java.util.stream.Collectors;
    +
    +public class OrdinalFunctions {
    +
    +    /**
    +     * Stellar Function: MAX
    +     * <p>
    +     * Return the maximum value of a list of input values in a Stellar list
    +     */
    --- End diff --
    
    It may be more clear to have MAX  | MIN  function for Numbers and a set of SORTED functions
for Strings.


---

Mime
View raw message