metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cestella <...@git.apache.org>
Subject [GitHub] metron pull request #832: METRON-1301 Sorting on Triage Score Unexpectedly F...
Date Tue, 07 Nov 2017 15:57:15 GMT
Github user cestella commented on a diff in the pull request:

    https://github.com/apache/metron/pull/832#discussion_r149411916
  
    --- Diff: metron-platform/metron-elasticsearch/src/main/java/org/apache/metron/elasticsearch/dao/ElasticsearchDao.java
---
    @@ -234,26 +366,43 @@ public synchronized void init(AccessConfig config) {
         if(this.client == null) {
           this.client = ElasticsearchUtils.getClient(config.getGlobalConfigSupplier().get(),
config.getOptionalSettings());
           this.accessConfig = config;
    +      this.columnMetadataDao = new ElasticsearchColumnMetadataDao(this.client.admin(),
Collections.singletonList(".kibana"));
    --- End diff --
    
    While I agree with the inclusion of `.kibana` here, what are the consequences for those
users with other, non-metron, indices?  Should we allow users to specify this list in the
REST application.yml?


---

Mime
View raw message