metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ottobackwards <...@git.apache.org>
Subject [GitHub] metron pull request #840: METRON-939: Upgrade ElasticSearch and Kibana
Date Fri, 10 Nov 2017 15:44:53 GMT
Github user ottobackwards commented on a diff in the pull request:

    https://github.com/apache/metron/pull/840#discussion_r150265577
  
    --- Diff: metron-platform/metron-elasticsearch/src/main/java/org/apache/metron/elasticsearch/dao/ElasticsearchDao.java
---
    @@ -139,13 +141,17 @@ protected SearchResponse search(SearchRequest searchRequest, QueryBuilder
queryB
         searchRequest.getSort().forEach(sortField -> searchSourceBuilder.sort(sortField.getField(),
getElasticsearchSortOrder(sortField.getSortOrder())));
         Optional<List<String>> fields = searchRequest.getFields();
         if (fields.isPresent()) {
    --- End diff --
    
    why not just remove?


---

Mime
View raw message