metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From justinleet <...@git.apache.org>
Subject [GitHub] metron pull request #824: METRON-1289: Alert fields are lost when a MetaAler...
Date Mon, 13 Nov 2017 19:30:59 GMT
Github user justinleet commented on a diff in the pull request:

    https://github.com/apache/metron/pull/824#discussion_r150641377
  
    --- Diff: metron-platform/metron-indexing/src/test/java/org/apache/metron/indexing/dao/InMemoryMetaAlertDao.java
---
    @@ -200,4 +207,23 @@ public MetaAlertCreateResponse createMetaAlert(MetaAlertCreateRequest
request)
         createResponse.setCreated(true);
         return createResponse;
       }
    +
    +  @Override
    +  public boolean addAlertsToMetaAlert(String metaAlertGuid, Collection<String>
alertGuids,
    +      Collection<String> sensorTypes) throws IOException {
    +    return true;
    --- End diff --
    
    MetaAlertControllerIntegrationTest would be the best place to add these integration tests,
and I think they should be added to make sure the REST calls line up the way we do everything
else.


---

Mime
View raw message