metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From JonZeolla <...@git.apache.org>
Subject [GitHub] metron issue #827: METRON-1294: IP addresses are not formatted correctly in ...
Date Thu, 16 Nov 2017 19:53:54 GMT
Github user JonZeolla commented on the issue:

    https://github.com/apache/metron/pull/827
  
    I didn't get myself intimately familiar with this PR, but I wanted to mention that assuming
two fields with the same name but different types between indexes are not the same may not
always hold.  For instance, in bro there are a couple of field names that overlap between
bro logs, and so the type in the bro index needs to be one that can commonly work (usually
string), but if there was no overlap it would be a different type.  [Example](https://github.com/JonZeolla/metron/blob/master/metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/files/bro_index.template#L131-L134).
 Not even positive this is relevant (especially given `getCommonColumnMetadata` may just get
removed), but in case it is I wanted to mention it.


---

Mime
View raw message