metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From merrimanr <>
Subject [GitHub] metron issue #827: METRON-1294: IP addresses are not formatted correctly in ...
Date Thu, 16 Nov 2017 21:17:11 GMT
Github user merrimanr commented on the issue:
    @JonZeolla I think we should just remove it for now and I've done that in the latest commit.
 I'm not entirely clear on what we should expect in this case and we don't need it right now
anyways.  Better to implement it the right way once we are clear on how it should behave in
my opinion.
    Good catch @justinleet!  I did not think of this test case and to my surprise the Elasticsearch
API returns ALL field mappings if you pass in an empty array of indices.  I will fix this
and add a test case.  You are correct in that we should expect correctly formatted ip addresses
in "facetCounts".  Before this PR they would have been in long format when you include an
index that does not have a mapping for the ip_src_addr field.


View raw message