metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jjmeyer0 <...@git.apache.org>
Subject [GitHub] metron pull request #814: METRON-1277 Add match statement to Stellar languag...
Date Wed, 22 Nov 2017 02:45:45 GMT
Github user jjmeyer0 commented on a diff in the pull request:

    https://github.com/apache/metron/pull/814#discussion_r152456690
  
    --- Diff: metron-stellar/stellar-common/src/main/antlr4/org/apache/metron/stellar/common/generated/Stellar.g4
---
    @@ -254,6 +259,7 @@ identifier_operand :
       | EXISTS LPAREN IDENTIFIER RPAREN #ExistsFunc
       | LPAREN conditional_expr RPAREN #condExpr_paren
       | functions #func
    +  | DEFAULT #Default
    --- End diff --
    
    I just noticed this. Why do we have default here? This would allow default to be used
in some unintended places. Is there some reasoning behind this? 


---

Mime
View raw message