metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From merrimanr <...@git.apache.org>
Subject [GitHub] metron pull request #824: METRON-1289: Alert fields are lost when a MetaAler...
Date Wed, 01 Nov 2017 21:25:49 GMT
GitHub user merrimanr opened a pull request:

    https://github.com/apache/metron/pull/824

    METRON-1289: Alert fields are lost when a MetaAlert is created

    ## Contributor Comments
    This PR fixes a bug in the ElasticsearchMetaAlertDao that incorrectly updates the included
alerts.  To reproduce this error, pick any alert and record it's guid.  Then create a metaalert
with the http://node1:8082/swagger-ui.html#!/meta-alert-controller/createUsingPOST endpoint:
    ```
    {
      "groups": [
        "string"
      ],
      "guidToIndices": {"dcb3afed-1b68-d88a-7adb-f38183867920":"bro_index_2017.11.01.13"}
    }
    ```
    Now perform a lookup on the same alert with the http://node1:8082/swagger-ui.html#!/search-controller/getLatestUsingPOST
endpoint:
    ```
    {
      "guid": "dcb3afed-1b68-d88a-7adb-f38183867920",
      "sensorType": "bro"
    }
    ```
    The result only contains the "metaalert" field:
    ```
    {
      "metaalerts": [
        "87ce1d82-aa09-4a1a-8be9-b9e7b76859b9"
      ]
    }
    ```
    This PR corrects this error by updating the alert with the full object instead of a partial
object.  After this PR, following the steps above should return the full object including
the new "metaalert" field.
    
    A `getAllLatest` function was added to make IndexDao match the pattern used for findOne.
 An HBase implementation was not added because it seemed unnecessary but it could be if it
makes sense.  Test cases were added to catch the error above and for the new `getAllLatest`
function.  This has been verified in full dev.
    
    ## Pull Request Checklist
    
    Thank you for submitting a contribution to Apache Metron.  
    Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235)
for the complete guide to follow for contributions.  
    Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview)
for complete smoke testing guides.  
    
    
    In order to streamline the review of the contribution we ask you follow these guidelines
and ask you to double check the following:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at
[Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).

    - [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are
trying to resolve? Pay particular attention to the hyphen "-" character.
    - [x] Has your PR been rebased against the latest commit within the target branch (typically
master)?
    
    
    ### For code changes:
    - [x] Have you included steps to reproduce the behavior or problem that is being changed
or addressed?
    - [x] Have you included steps or a guide to how the change may be verified and tested
manually?
    - [x] Have you ensured that the full suite of tests and checks have been executed in the
root metron folder via:
      ```
      mvn -q clean integration-test install && build_utils/verify_licenses.sh 
      ```
    
    - [x] Have you written or updated unit tests and or integration tests to verify your changes?
    - [x] If adding new dependencies to the code, are these dependencies licensed in a way
that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

    - [x] Have you verified the basic functionality of the build by building and running locally
with Vagrant full-dev environment or the equivalent?
    
    ### For documentation related changes:
    - [x] Have you ensured that format looks appropriate for the output in which it is rendered
by building and verifying the site-book? If not then run the following commands and the verify
changes via `site-book/target/site/index.html`:
    
      ```
      cd site-book
      mvn site
      ```
    
    #### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible.
    It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal
repository such that your branches are built there before submitting a pull request.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/merrimanr/incubator-metron METRON-1289

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/metron/pull/824.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #824
    
----
commit c26a36f8d1a5d0a4cec9166f777013247b6ca199
Author: merrimanr <merrimanr@gmail.com>
Date:   2017-11-01T21:09:42Z

    initial commit

----


---

Mime
View raw message