metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cestella <...@git.apache.org>
Subject [GitHub] metron pull request #851: METRON-1336 Patching Can Result in Bad Configurati...
Date Mon, 04 Dec 2017 14:33:35 GMT
Github user cestella commented on a diff in the pull request:

    https://github.com/apache/metron/pull/851#discussion_r154663544
  
    --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/configuration/ConfigurationsUtils.java
---
    @@ -343,25 +343,57 @@ public static void uploadConfigsToZookeeper(String rootFilePath,
CuratorFramewor
        * @param type config type to upload configs for
        * @param configName specific config under the specified config type
        */
    -  public static void uploadConfigsToZookeeper(String rootFilePath, CuratorFramework client,
    -      ConfigurationType type, Optional<String> configName) throws Exception {
    +  public static void uploadConfigsToZookeeper(
    +          String rootFilePath,
    +          CuratorFramework client,
    +          ConfigurationType type,
    +          Optional<String> configName) throws Exception {
    +
         switch (type) {
    +
           case GLOBAL:
             final byte[] globalConfig = readGlobalConfigFromFile(rootFilePath);
             if (globalConfig.length > 0) {
               setupStellarStatically(client, Optional.of(new String(globalConfig)));
               writeGlobalConfigToZookeeper(globalConfig, client);
             }
             break;
    -      case PARSER: // intentional pass-through
    -      case ENRICHMENT: // intentional pass-through
    -      case INDEXING:
    -        Map<String, byte[]> sensorIndexingConfigs = readSensorConfigsFromFile(rootFilePath,
type,
    -            configName);
    -        for (String sensorType : sensorIndexingConfigs.keySet()) {
    -          writeConfigToZookeeper(type, configName, sensorIndexingConfigs.get(sensorType),
client);
    +
    +      case PARSER: {
    +        Map<String, byte[]> configs = readSensorConfigsFromFile(rootFilePath, PARSER,
configName);
    --- End diff --
    
    The meta-PR is merged


---

Mime
View raw message