metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nickwallen <...@git.apache.org>
Subject [GitHub] metron pull request #871: METRON-1365: Allow PROFILE_GET to return a default...
Date Mon, 18 Dec 2017 02:19:21 GMT
Github user nickwallen commented on a diff in the pull request:

    https://github.com/apache/metron/pull/871#discussion_r157390718
  
    --- Diff: metron-analytics/metron-profiler-client/src/main/java/org/apache/metron/profiler/client/stellar/ProfilerClientConfig.java
---
    @@ -56,8 +56,11 @@
       /**
        * A global property that defines the salt divisor used to store profile data.
        */
    -  PROFILER_SALT_DIVISOR("profiler.client.salt.divisor", 1000L, Long.class);
    -
    +  PROFILER_SALT_DIVISOR("profiler.client.salt.divisor", 1000L, Long.class)
    +  /**
    +   * The default value to be returned if a profile is not written for a given period
for a profile and entity.
    +   */
    +  ,PROFILER_DEFAULT_VALUE("profiler.default.value", null, Object.class);
    --- End diff --
    
    Small nits... Add a space above this field and move the comma so that it matches the rest
of the file


---

Mime
View raw message