metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From merrimanr <...@git.apache.org>
Subject [GitHub] metron pull request #831: METRON-1302: Split up Indexing Topology into batch...
Date Tue, 02 Jan 2018 21:40:40 GMT
Github user merrimanr commented on a diff in the pull request:

    https://github.com/apache/metron/pull/831#discussion_r159321881
  
    --- Diff: metron-platform/metron-indexing/src/test/java/org/apache/metron/indexing/integration/IndexingIntegrationTest.java
---
    @@ -197,9 +140,7 @@ public void test() throws Exception {
           //assert that our input docs are equivalent to the output docs, converting the
input docs keys based
           // on the field name converter
           assertInputDocsMatchOutputs(inputDocs, docs, getFieldNameConverter());
    -      assertInputDocsMatchOutputs(inputDocs, readDocsFromDisk(hdfsDir), x -> x);
    -    } catch(Throwable e) {
    -      e.printStackTrace();
    +      //assertInputDocsMatchOutputs(inputDocs, readDocsFromDisk(hdfsDir), x -> x);
    --- End diff --
    
    Is this comment intentional?


---

Mime
View raw message