metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nickwallen <...@git.apache.org>
Subject [GitHub] metron pull request #884: METRON-1382 Run Stellar in a Zeppelin Notebook
Date Wed, 03 Jan 2018 18:56:25 GMT
Github user nickwallen commented on a diff in the pull request:

    https://github.com/apache/metron/pull/884#discussion_r159498085
  
    --- Diff: metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/common/shell/StellarResult.java
---
    @@ -0,0 +1,185 @@
    +/*
    + *
    + *  Licensed to the Apache Software Foundation (ASF) under one
    + *  or more contributor license agreements.  See the NOTICE file
    + *  distributed with this work for additional information
    + *  regarding copyright ownership.  The ASF licenses this file
    + *  to you under the Apache License, Version 2.0 (the
    + *  "License"); you may not use this file except in compliance
    + *  with the License.  You may obtain a copy of the License at
    + *
    + *      http://www.apache.org/licenses/LICENSE-2.0
    + *
    + *  Unless required by applicable law or agreed to in writing, software
    + *  distributed under the License is distributed on an "AS IS" BASIS,
    + *  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + *  See the License for the specific language governing permissions and
    + *  limitations under the License.
    + *
    + */
    +package org.apache.metron.stellar.common.shell;
    +
    +import java.util.Optional;
    +
    +/**
    + * The result of executing a Stellar expression within a StellarShellExecutor.
    + */
    +public class StellarResult {
    --- End diff --
    
    Instead of the Stellar executor just returning an Object like before (which doesn't tell
me much about whether the operations was successful or not) I needed a more descriptive result
like this.  
    
    This is how the CLI and Zeppelin REPLs determine whether the Stellar expression was executed
successfully or not.  They need to perform different actions based on success, failure or
even if there is a termination request.


---

Mime
View raw message