metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From justinleet <...@git.apache.org>
Subject [GitHub] metron issue #786: METRON-1231: Separate Sensor name and topic in the Manage...
Date Fri, 05 Jan 2018 13:11:08 GMT
Github user justinleet commented on the issue:

    https://github.com/apache/metron/pull/786
  
    I took a swing through this, and generally this worked as expected. There were a couple
things in full dev that I'm not sure if they were preexisting or not, just from unfamiliarity
with how it worked before.  If these things are preexisting, it might be worth a follow on
task to clean up.
    
    1. If I try to create a new sensor without a name, I get an error "Unable to save sensor
config: Request method 'POST' not supported".  We should be able to give a more informative
error, and really it should be on the fly like validation like the Kafka topic name.
    
    1. If a field is missing in a new sensor (e.g. topic or GROK statement), I get "Unexpected
end of JSON input".  This makes me worry there's a structural problem in the request, along
with the lack of informative error.
    
    1. The UI will happily let me try to recreate an existing sensor, and apparently executes
an update.  I would expect it to refuse to let me override an existing sensor.  This includes
on a running sensor, which is worrisome.
    
    1. If we get a permission denied error while editing a parser (e.g. I tried to edit squid
and hit HDFS permissions), we throw a giant stack trace on the screen.


---

Mime
View raw message