metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nickwallen <...@git.apache.org>
Subject [GitHub] metron pull request #884: METRON-1382 Run Stellar in a Zeppelin Notebook
Date Fri, 05 Jan 2018 23:04:59 GMT
Github user nickwallen commented on a diff in the pull request:

    https://github.com/apache/metron/pull/884#discussion_r159999794
  
    --- Diff: metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/common/shell/StellarExecutionListeners.java
---
    @@ -0,0 +1,51 @@
    +/*
    + *
    + *  Licensed to the Apache Software Foundation (ASF) under one
    + *  or more contributor license agreements.  See the NOTICE file
    + *  distributed with this work for additional information
    + *  regarding copyright ownership.  The ASF licenses this file
    + *  to you under the Apache License, Version 2.0 (the
    + *  "License"); you may not use this file except in compliance
    + *  with the License.  You may obtain a copy of the License at
    + *
    + *      http://www.apache.org/licenses/LICENSE-2.0
    + *
    + *  Unless required by applicable law or agreed to in writing, software
    + *  distributed under the License is distributed on an "AS IS" BASIS,
    + *  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + *  See the License for the specific language governing permissions and
    + *  limitations under the License.
    + *
    + */
    +package org.apache.metron.stellar.common.shell;
    +
    +import org.apache.metron.stellar.common.shell.specials.SpecialCommand;
    +import org.apache.metron.stellar.dsl.StellarFunctionInfo;
    +
    +/**
    + * A listener will be notified about events that occur during the
    + * execution of Stellar expressions.
    + */
    +public class StellarExecutionListeners {
    +
    +  /**
    +   * A listener that is notified when a function is defined.
    +   */
    +  public interface FunctionDefinedListener {
    +    void whenFunctionDefined(StellarFunctionInfo functionInfo);
    +  }
    --- End diff --
    
    I don't see how this would cause a leak.  Yes, in some cases listeners can cause troubles,
but I don't see how it is a problem here.  Can you be more specific?  Otherwise, I don't know
what needs a fixin' here.


---

Mime
View raw message