metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nickwallen <>
Subject [GitHub] metron issue #884: METRON-1382 Run Stellar in a Zeppelin Notebook
Date Fri, 05 Jan 2018 23:18:31 GMT
Github user nickwallen commented on the issue:
    > Also, do we now have to validate in both environments when we make changes to the
shell? that should also be spelt out.
    No you do not have to validate in both.  The point of all this refactoring was so that
we don't have duplicate logic between the CLI REPL and Zeppelin.
    (1) There is the `shell.StellarShell` that has all the Aesh code to drive the CLI shell.
    (2) There is the `zeppelin.StellarInterpreter` that has all the logic to interact with
    (3) Finally there is the `shell.StellarShellExecutor` that is used by both (1) and (2)
to handle Stellar and our Stellar "extensions" like assignment, comments, etc.
    All of this now has a plethora of unit tests; tests that we didn't have before.  So I
think this puts us in a better position to avoid future regressions.


View raw message