metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cestella <...@git.apache.org>
Subject [GitHub] metron issue #831: METRON-1302: Split up Indexing Topology into batch and ra...
Date Mon, 08 Jan 2018 14:54:24 GMT
Github user cestella commented on the issue:

    https://github.com/apache/metron/pull/831
  
    @nickwallen Whoops, sorry, I totally misunderstood.  This PR *is* how *I* would like it.
  I'm just going to copy this here to justify my position:
    ```
    The reason why I preferred to do that was that when we do a better job of including Solr
or other indices, prefixing the variables elasticsearch will be confusing. The flux files
are generic to the writer type for the random access indices. I can understand the confusion
for the user given we only really support HDFS and elasticsearch right now, which is why I
changed the display names and kept the command line clients named as they were before. Eventually,
when we provide actual proper extension points to the indices, we should genericize the display
names and scripts IMO.
    ```
    
    I hope that clarifies my position on the matter (or at least why I made it the way it
is).  If there are other thoughts, I'd like to be able to discuss them.  @mmiklavc chimed
in in support, but I'd like to hear differing opinions if my argument is not persuasive.


---

Mime
View raw message