metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From justinleet <...@git.apache.org>
Subject [GitHub] metron pull request #879: METRON-1378: Create a summarizer
Date Mon, 08 Jan 2018 17:45:31 GMT
Github user justinleet commented on a diff in the pull request:

    https://github.com/apache/metron/pull/879#discussion_r160177446
  
    --- Diff: metron-platform/metron-data-management/src/main/java/org/apache/metron/dataloads/nonbulk/flatfile/importer/AbstractLocalImporter.java
---
    @@ -0,0 +1,161 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.metron.dataloads.nonbulk.flatfile.importer;
    +
    +import org.apache.hadoop.conf.Configuration;
    +import org.apache.hadoop.fs.FileSystem;
    +import org.apache.metron.common.utils.file.ReaderSpliterator;
    +import org.apache.metron.dataloads.extractor.ExtractorHandler;
    +import org.apache.metron.dataloads.extractor.inputformat.WholeFileFormat;
    +import org.apache.metron.common.utils.cli.CLIOptions;
    +import org.apache.metron.dataloads.nonbulk.flatfile.LoadOptions;
    +import org.apache.metron.dataloads.nonbulk.flatfile.location.Location;
    +import org.apache.metron.dataloads.nonbulk.flatfile.location.LocationStrategy;
    +
    +import java.io.BufferedReader;
    +import java.io.IOException;
    +import java.util.ArrayList;
    +import java.util.EnumMap;
    +import java.util.List;
    +import java.util.Optional;
    +import java.util.concurrent.ForkJoinPool;
    +import java.util.stream.Collectors;
    +import java.util.stream.Stream;
    +
    +public abstract class AbstractLocalImporter<OPTIONS_T extends Enum<OPTIONS_T>
& CLIOptions, STATE_T>  implements Importer<OPTIONS_T> {
    +
    +  @Override
    +  public void importData( final EnumMap<OPTIONS_T, Optional<Object>> config
    +                        , final ExtractorHandler handler
    +                        , final Configuration hadoopConfig
    +                         ) throws IOException {
    +    validateState(config, handler);
    +    ThreadLocal<STATE_T> state = createState(config, hadoopConfig, handler);
    +    boolean quiet = isQuiet(config);
    +    boolean lineByLine = !handler.getInputFormat().getClass().equals(WholeFileFormat.class);
    +    List<String> inputs = getInputs(config);
    +    FileSystem fs = FileSystem.get(hadoopConfig);
    +    if(!lineByLine) {
    +      extractWholeFiles(inputs, fs, state, quiet);
    +    }
    +    else {
    +      int batchSize = batchSize(config);
    +      int numThreads = numThreads(config, handler);
    +      extractLineByLine(inputs, fs, state, batchSize, numThreads, quiet);
    +    }
    +    if(!quiet) {
    +      System.out.println();
    +    }
    +  }
    +
    +  protected abstract List<String> getInputs(final EnumMap<OPTIONS_T, Optional<Object>>
config);
    +  protected abstract boolean isQuiet(final EnumMap<OPTIONS_T, Optional<Object>>
config);
    +  protected abstract int batchSize(final EnumMap<OPTIONS_T, Optional<Object>>
config);
    +  protected abstract int numThreads(final EnumMap<OPTIONS_T, Optional<Object>>
config, ExtractorHandler handler);
    +
    +  protected abstract void validateState(final EnumMap<OPTIONS_T, Optional<Object>>
config
    +                                       ,final ExtractorHandler handler
    +                                       );
    +
    +  protected abstract ThreadLocal<STATE_T> createState( final EnumMap<OPTIONS_T,
Optional<Object>> config
    +                                                     , final Configuration hadoopConfig
    +                                                     , final ExtractorHandler handler
    +                                                     );
    +
    +  protected abstract void extract(STATE_T state
    +                                 , String line
    +                                 ) throws IOException;
    +
    +  protected Location resolveLocation(String input, FileSystem fs) {
    +    return LocationStrategy.getLocation(input, fs);
    +  }
    +
    +  public void extractLineByLine( List<String> inputs
    --- End diff --
    
    It's not something I'd want any work done on here, but have we put any thought into having
this be a generic delimiter for lines, rather than just lines?  It's probably just a light
refactoring, but it's always really annoying to me when I need a non-newline delimiter and
then end up not being able to trivially specify it. It's uncommon, but it does seem to pop
up now and again.


---

Mime
View raw message