metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From justinleet <...@git.apache.org>
Subject [GitHub] metron pull request #879: METRON-1378: Create a summarizer
Date Mon, 08 Jan 2018 17:45:31 GMT
Github user justinleet commented on a diff in the pull request:

    https://github.com/apache/metron/pull/879#discussion_r160208209
  
    --- Diff: metron-platform/metron-data-management/src/main/java/org/apache/metron/dataloads/nonbulk/flatfile/writer/Writer.java
---
    @@ -0,0 +1,34 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.metron.dataloads.nonbulk.flatfile.writer;
    +
    +import org.apache.hadoop.conf.Configuration;
    +import org.apache.metron.common.utils.SerDeUtils;
    +
    +import java.io.IOException;
    +import java.util.Optional;
    +
    +public interface Writer {
    +  void validate(Optional<String> output, Configuration hadoopConfig);
    --- End diff --
    
    Why doesn't this either return something or throw a checked exception? Right now the validate
method is just something that you call and it doesn't do anything except throw runtime exception
in the impls, rather than giving the caller an explicit ability to do anything about the validation
failure.
      


---

Mime
View raw message