metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From justinleet <...@git.apache.org>
Subject [GitHub] metron issue #853: METRON-1337: List of facets should not be hardcoded
Date Tue, 09 Jan 2018 17:13:38 GMT
Github user justinleet commented on the issue:

    https://github.com/apache/metron/pull/853
  
    To respond to the questions in the description (and maybe kick off conversation, especially
if anyone disagrees) + add my own thoughts.  In no particular order.
    
    @merrimanr Let me know if I'm misunderstanding anything as well, I'm digging into this
for the first time
    
    1. This feels like a user specific config.  Having a default that each user gets if they
don't do anything seems appropriate, but I'd expect different people to want to be looking
at different things.
    1. The DB feels like a reasonable place for this to live.  We're already storing some
per user type data (e.g. recent searches) in the DB, right?
    1. It would be nice to have (and this would be follow-on), a really easy UI way to adjust
the facet fields.  Especially, if it's that adjustable on the fly, I don't think we need versioning
on the user level facet configs.
    1. IMO, having the defaults be versioned is nice, but not mandatory (we don't version
anything in that file, do we?)
    1. Re: the upgrade issue.  We generally don't support upgrades, but having the upgrading.md
have a note along with at least a couple of the basic commands to add that field would be
nice.
    1. I'd have a slight inclination towards empty facet array being default and missing being
disable.  It's more intuitive for me that if I leave it out of the request, it's not present.



---

Mime
View raw message