metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ottobackwards <...@git.apache.org>
Subject [GitHub] metron issue #865: METRON-1212 The bundle System and Maven Plugin (Feature B...
Date Fri, 12 Jan 2018 15:13:45 GMT
Github user ottobackwards commented on the issue:

    https://github.com/apache/metron/pull/865
  
    __**BUMP**__
    
    @nickwallen , @mmiklavc , @cestella : leaving a breadcrumb so you can follow the PR to
here.  This is now a feature branch and is broken up as you requested, so it is the sum of
all things.
    
    @mattf-horton : I would request, if you are comfortable doing so, moving your implicit
+1 for this code to an explicit +1 on this pr to give the option of getting the feature branch
moving, as this effort has again stagnated for weeks.  If you feel your prior review is obsolete
because of the changes for merging contexts and the new testing sample code and documentation
added to address review comments, that is understandable.  My question then is how we handle
that.
    
    I am not sure how we want to proceed here.  The stated idea was if this were broken up
into smaller chunks, we would take the already reviewed first chunk and be able to reasonably
quickly get that landed to move things alone.  That has not happened.  I have done further
work to make this a feature branch, which I think is correct, and gets us, in the end and
after much work to where we would have wanted to be at the start, a clean feature branch with
broken down submittals.  I am out of things I can do with this to make it more reviewable.



---

Mime
View raw message