metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From anandsubbu <...@git.apache.org>
Subject [GitHub] metron pull request #888: METRON-1389: Zeppelin notebook import does not wor...
Date Mon, 22 Jan 2018 18:18:43 GMT
Github user anandsubbu commented on a diff in the pull request:

    https://github.com/apache/metron/pull/888#discussion_r163022818
  
    --- Diff: metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/scripts/indexing_master.py
---
    @@ -150,12 +152,48 @@ def zeppelin_notebook_import(self, env):
             env.set_params(params)
     
             Logger.info(ambari_format('Searching for Zeppelin Notebooks in {metron_config_zeppelin_path}'))
    +
    +        # With Ambari 2.5+, Zeppelin server is enabled to work with Shiro authentication,
which requires user/password
    +        # for authentication (see https://zeppelin.apache.org/docs/0.6.0/security/shiroauthentication.html
for details).
    +        ses = requests.session()
    --- End diff --
    
    Sure thing @nickwallen  . Please see latest commit where I have refactored this into a
separate method. 
    
    Further, I tested the latest changes on a full-dev environment (w/Ambari 2.4.2) as well
as a 12-node cluster (w/Ambari 2.6.0) to confirm the notebooks are imported fine.


---

Mime
View raw message