metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mmiklavc <...@git.apache.org>
Subject [GitHub] metron issue #909: METRON-1429: SearchIntegrationTest refactor
Date Thu, 25 Jan 2018 14:55:51 GMT
Github user mmiklavc commented on the issue:

    https://github.com/apache/metron/pull/909
  
    @cestella You're right about that - the general goodness. We (I) had made the mistake
of doing some test refactoring in the ES upgrade branch that would have been better done in
a separate PR, committed to master, and then pulled into the ES branch. Splitting out improvements/refactorings
the way Ryan did here means everyone gets the benefit, and further changes or enhancements
don't get mangled in repeated merges in the Solr feature branch.


---

Mime
View raw message