metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cestella <...@git.apache.org>
Subject [GitHub] metron pull request #910: METRON-1430: Isolate jackson from being used as ar...
Date Thu, 25 Jan 2018 19:40:05 GMT
GitHub user cestella opened a pull request:

    https://github.com/apache/metron/pull/910

    METRON-1430: Isolate jackson from being used as arguments or returns from JSONUtils

    ## Contributor Comments
    Currently jackson is used as part of our internal API to JSONUtils.  The problem here
is when we shade and relocate jackson.  Suddenly we can't use JSONUtils.  We should avoid
operating on jackson primitives and rather provide a convenient wrapper around the places
where we use jackson as part of the API.
    
    This is required for #907 because this is where we are forced to relocate jackson and
there is a competing version on the classpath.
    
    Validate by running up vagrant and ensuring data flows through all topologies, data shows
up in the alerts UI.
    
    ## Pull Request Checklist
    
    Thank you for submitting a contribution to Apache Metron.  
    Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235)
for the complete guide to follow for contributions.  
    Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview)
for complete smoke testing guides.  
    
    
    In order to streamline the review of the contribution we ask you follow these guidelines
and ask you to double check the following:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at
[Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).

    - [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are
trying to resolve? Pay particular attention to the hyphen "-" character.
    - [x] Has your PR been rebased against the latest commit within the target branch (typically
master)?
    
    
    ### For code changes:
    - [x] Have you included steps to reproduce the behavior or problem that is being changed
or addressed?
    - [x] Have you included steps or a guide to how the change may be verified and tested
manually?
    - [x] Have you ensured that the full suite of tests and checks have been executed in the
root metron folder via:
      ```
      mvn -q clean integration-test install && build_utils/verify_licenses.sh 
      ```
    
    - [x] Have you written or updated unit tests and or integration tests to verify your changes?
    - [x] If adding new dependencies to the code, are these dependencies licensed in a way
that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

    - [ ] Have you verified the basic functionality of the build by building and running locally
with Vagrant full-dev environment or the equivalent?
    
    
    #### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible.
    It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal
repository such that your branches are built there before submitting a pull request.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cestella/incubator-metron jackson_api_isolation

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/metron/pull/910.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #910
    
----
commit 2f553e85ca8cf41d35395c6e85d70aab7b39db09
Author: cstella <cestella@...>
Date:   2018-01-25T18:59:18Z

    Isolate JSONUtils.load from exposing Jackson

commit 9c8b3bd821f8feb2f4d39ca640706ebb7a89dbe6
Author: cstella <cestella@...>
Date:   2018-01-25T19:32:43Z

    Updating JSONUtils to avoid exposing jackson

----


---

Mime
View raw message