metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From merrimanr <...@git.apache.org>
Subject [GitHub] metron pull request #917: METRON-1435: Management UI cannot save json object...
Date Tue, 30 Jan 2018 22:21:43 GMT
GitHub user merrimanr opened a pull request:

    https://github.com/apache/metron/pull/917

    METRON-1435: Management UI cannot save json objects in advanced config

    ## Contributor Comments
    This PR fixes a bug in the Management UI that limits a user to only entering strings in
the Advanced Config section.  This can be verified in full dev by navigating to the Management
UI and editing the bro sensor.  Expand the Advanced Config by clicking on the "Advanced" link
at the bottom of the main panel.  In the "PARSER CONFIG" section, enter a field name and `["value"]`
as the value.  Use Swagger to get the bro config and the parserConfig should look like:
    ```
    {
      ...
      "parserConfig": {
        "field": ["value"]
      }
    }
    ```
    Before this PR the parserConfig would have been incorrectly converted to a string:
    ```
    {
      ...
      "parserConfig": {
        "field": "[\"value\"]"
      }
    }
    ```
    This will also work for json objects as well as arrays.
    
    ## Pull Request Checklist
    
    Thank you for submitting a contribution to Apache Metron.  
    Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235)
for the complete guide to follow for contributions.  
    Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview)
for complete smoke testing guides.  
    
    
    In order to streamline the review of the contribution we ask you follow these guidelines
and ask you to double check the following:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at
[Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
    - [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are
trying to resolve? Pay particular attention to the hyphen "-" character.
    - [x] Has your PR been rebased against the latest commit within the target branch (typically
master)?
    
    
    ### For code changes:
    - [ ] Have you included steps to reproduce the behavior or problem that is being changed
or addressed?
    - [ ] Have you included steps or a guide to how the change may be verified and tested
manually?
    - [ ] Have you ensured that the full suite of tests and checks have been executed in the
root metron folder via:
      ```
      mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh

      ```
    
    - [x] Have you written or updated unit tests and or integration tests to verify your changes?
    - [x] If adding new dependencies to the code, are these dependencies licensed in a way
that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
    - [x] Have you verified the basic functionality of the build by building and running locally
with Vagrant full-dev environment or the equivalent?
    
    ### For documentation related changes:
    - [] Have you ensured that format looks appropriate for the output in which it is rendered
by building and verifying the site-book? If not then run the following commands and the verify
changes via `site-book/target/site/index.html`:
    
      ```
      cd site-book
      mvn site
      ```
    
    #### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible.
    It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal
repository such that your branches are built there before submitting a pull request.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/merrimanr/incubator-metron METRON-1435

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/metron/pull/917.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #917
    
----
commit 1a58b1a109ca44f4c44ab0a62d29f323cb1cf969
Author: merrimanr <merrimanr@...>
Date:   2018-01-30T22:12:53Z

    initial commit

----


---

Mime
View raw message