metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Justin Leet <justinjl...@gmail.com>
Subject Re: Bro plugin unit tests failing
Date Mon, 15 Oct 2018 14:09:37 GMT
I can go ahead and draft an email, but it'll probably be later today or
possibly tomorrow.  If someone else wants to put out a thread before then,
feel free.

On Mon, Oct 15, 2018 at 10:06 AM Zeolla@GMail.com <zeolla@gmail.com> wrote:

> All good suggestions.  I don't think I'll personally have time in the
> short term to draft a release discussion email, but I do think it's a good
> idea.
>
> I can take a stab at the README link to contributing and a PR template for
> the plugin repo.
>
> Jon
>
> On Mon, Oct 15, 2018 at 8:09 AM Justin Leet <justinjleet@gmail.com> wrote:
>
>> Should we just put out a discuss for releasing in general, with this
>> discussion noted?  The outcome of the release cadence discussion was to put
>> out a thread around each board report. I believe that's a few days from
>> now, so it's good timing. As an aside, part of the post release activities
>> for the plugin should probably be upping the plugin version in the main
>> repo to use the new version.
>>
>> While we're on the topic, is there anything else we should do to improve
>> the plugin repo?  Off the top of my head, setting up a version of the PR
>> template would be helpful.  Maybe adding a section to the README.md linking
>> to the CONTRIBUTING.md of the main repo?
>>
>> On Sun, Oct 14, 2018 at 11:14 AM Otto Fowler <ottobackwards@gmail.com>
>> wrote:
>>
>>> It is INFRA, see INFRA-17091 for example.
>>>
>>>
>>> On October 12, 2018 at 20:47:24, Zeolla@GMail.com (zeolla@gmail.com)
>>> wrote:
>>>
>>> So it seems that the last commit before the 0.2 release of
>>> metron-bro-plugin-kafka broke the one basic unit test that we had. Since
>>> metron 0.6.0 pins to 0.1
>>> <
>>>
>>> https://github.com/apache/metron/blob/Metron_0.6.0/metron-deployment/ansible/roles/bro/vars/main.yml#L30
>>> >
>>>
>>> this wouldn't cause an obvious issue if you spun up the sensors in
>>> full-dev, and even if we were to point metron to 0.2 of the plugin we
>>> wouldn't have necessarily seen the issue because we do a --force
>>> <
>>>
>>> https://github.com/apache/metron/blob/Metron_0.6.0/metron-deployment/ansible/roles/bro/tasks/metron-bro-plugin-kafka.yml#L35
>>> >
>>>
>>> to remove interaction.
>>>
>>> After we get a chance to review/merge a recent PR
>>> <https://github.com/apache/metron-bro-plugin-kafka/pull/2>, we should
>>> have
>>> a few more 'actual' unit tests, and I would like to get travis setup for
>>> the repo <https://travis-ci.org/apache/metron-bro-plugin-kafka> to
>>> actually
>>> check those (PR incoming) so it's less likely this sort of thing would
>>> happen again. However, it doesn't appear I have the right permissions to
>>> be able to get travis moving on my own. Does anybody else have the right
>>> access, or is this an asf infrastructure ticket?
>>>
>>> I'd also like us to consider doing a 0.3 release for the plugin so we
>>> aren't distributing something that has broken tests. Thoughts on that?
>>>
>>> Jon
>>> --
>>>
>>> Jon
>>>
>> --
>
> Jon
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message