metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zeolla@GMail.com" <zeo...@gmail.com>
Subject Re: Bro plugin release process docs?
Date Fri, 12 Oct 2018 16:07:19 GMT
I've updated the cwiki
<https://cwiki.apache.org/confluence/pages/diffpagesbyversion.action?pageId=66854770&selectedPageVersions=43&selectedPageVersions=40>
and opened a PR <https://github.com/apache/metron/pull/1236> for this, open
to feedback on any of the changes I made/suggested.  Since I assume we
wouldn't want to make any changes to releases retroactively, I added a note
to the cwiki to note the history (see "Historical Note" under section 5).
Thanks,

Jon

On Thu, Oct 11, 2018 at 11:05 AM Zeolla@GMail.com <zeolla@gmail.com> wrote:

> Okay, I'll PR something since I'm looking at it
>
> Jon
>
> On Thu, Oct 11, 2018 at 9:45 AM Justin Leet <justinjleet@gmail.com> wrote:
>
>> If I recall correctly, they were already different, presumably from the
>> more manual process, and I wanted keep things close to what they already
>> were before trying to clean that sort of thing up. We can definitely unify
>> them, and if we need to code in any exceptions to deal with pre-unified
>> versions, we can.  It just wasn't high on my priority list.
>>
>> In the script, the change to the separator itself is easy, but I'd have to
>> double check if there's anything else that needs to happen to make sure
>> tags and such line up.
>>
>> On Thu, Oct 11, 2018 at 9:18 AM Zeolla@GMail.com <zeolla@gmail.com>
>> wrote:
>>
>> > Is there a reason why the prefix for apache/metron ends with a -,
>> whereas
>> > the plugin ends with a _ separator?  I would like to see it more uniform
>> > using the _
>> >
>> > Jon
>> >
>> > On Thu, Oct 11, 2018 at 9:04 AM Justin Leet <justinjleet@gmail.com>
>> wrote:
>> >
>> > > That first half of that page will be rewritten in the next couple
>> days to
>> > > reflect the script to prepare release candidate; I didn't want to
>> change
>> > > that page until the PR actually went in.
>> > >
>> > > The release process, barring the KEYS issue (and a patch to the
>> script to
>> > > handle the bro plugin tag), is pretty much set to be managed
>> separately
>> > at
>> > > this point.  The docs just need an overhaul, so someone who's not me
>> > knows
>> > > what to do.
>> > >
>> > > On Wed, Oct 10, 2018 at 7:01 PM Zeolla@GMail.com <zeolla@gmail.com>
>> > wrote:
>> > >
>> > > > Yeah you're right when I looked closer to make the change it was
>> step
>> > 10.
>> > > > I pushed a manual 0.2 tag to metron-bro-plugin-kafka and did a quick
>> > > update
>> > > > to the cwiki, but it could use some additional love, especially if
>> we
>> > > want
>> > > > to split out the release processes generally.
>> > > >
>> > > > Jon
>> > > >
>> > > > On Wed, Oct 10, 2018 at 5:32 PM Justin Leet <justinjleet@gmail.com>
>> > > wrote:
>> > > >
>> > > > > Yeah, we need to update the release process instructions. It
>> should
>> > > > > actually be step 10 shouldn't it?  We want to keep the rc tag
>> as-is
>> > > > because
>> > > > > it may get rejected/cancelled, and update the final tag as the
>> > > release. I
>> > > > > already need to overhaul that page to reflect the addition of
the
>> RC
>> > > > > creation script, so I can also update it.
>> > > > >
>> > > > > I didn't remember there was a specific reason for the git tagging,
>> > so I
>> > > > > just followed the convention we used for the main repo, which
is
>> why
>> > we
>> > > > > have this problem.
>> > > > >
>> > > > > The release candidate script also needs to be updated (because
it
>> > needs
>> > > > to
>> > > > > know the proper prior tag to pull). It's not hard to do, but
we'll
>> > need
>> > > > to
>> > > > > open a Jira and update that portion of the script. It's pretty
>> easy
>> > to
>> > > > do,
>> > > > > it's just the portion here
>> > > > > <
>> > > > >
>> > > >
>> > >
>> >
>> https://github.com/apache/metron/blob/master/dev-utilities/release-utils/prepare-release-candidate#L245
>> > > > > >
>> > > > > .
>> > > > >
>> > > > > On Wed, Oct 10, 2018 at 5:09 PM Michael Miklavcic <
>> > > > > michael.miklavcic@gmail.com> wrote:
>> > > > >
>> > > > > > +1 to all of that from me, Jon. Thanks for taking care of
this.
>> > > > > >
>> > > > > > On Wed, Oct 10, 2018 at 2:34 PM Zeolla@GMail.com <
>> zeolla@gmail.com
>> > >
>> > > > > wrote:
>> > > > > >
>> > > > > > > I wonder if we should also update the
>> > > > > > >
>> > https://cwiki.apache.org/confluence/display/METRON/Release+Process
>> > > > > > > instructions
>> > > > > > > to include tagging for the bro plugin, or if we were
going to
>> > split
>> > > > out
>> > > > > > the
>> > > > > > > release processes?  I'd be happy to update the instructions
>> (Step
>> > > 8)
>> > > > if
>> > > > > > > that's the right place for now and I didn't miss a
new place
>> for
>> > > the
>> > > > > > plugin
>> > > > > > > release instructions.
>> > > > > > >
>> > > > > > > Jon
>> > > > > > >
>> > > > > > > On Wed, Oct 10, 2018 at 4:31 PM Zeolla@GMail.com <
>> > zeolla@gmail.com
>> > > >
>> > > > > > wrote:
>> > > > > > >
>> > > > > > > > So I was poking around on the plugin today and
noticed that
>> we
>> > > have
>> > > > > > > > a apache-metron-bro-plugin-kafka_0.2.0-release
and
>> > > > > > > apache-metron-bro-plugin-kafka_0.2.0-rc1
>> > > > > > > > tag, but no 0.2 (which is what bro-pkg would point
to).
>> > Anybody
>> > > > have
>> > > > > > any
>> > > > > > > > concerns if I push the 0.2 tag as discussed above?
 Then we
>> > could
>> > > > > > update
>> > > > > > > > the bro package manager, and finally update what
the
>> > > apache/metron
>> > > > > > > full-dev
>> > > > > > > > environment(s) point to (0.2 as opposed to 0.1).
 Thanks,
>> > > > > > > >
>> > > > > > > > Jon
>> > > > > > > >
>> > > > > > > > On Mon, May 28, 2018 at 8:41 AM Zeolla@GMail.com
<
>> > > zeolla@gmail.com
>> > > > >
>> > > > > > > wrote:
>> > > > > > > >
>> > > > > > > >> I did a bit of poking around and I don't believe
we ever
>> > > formally
>> > > > > > wrote
>> > > > > > > >> that down.  The last release happened as a
combination of
>> > > actions
>> > > > > from
>> > > > > > > >> mattf and myself (mostly mattf).
>> > > > > > > >>
>> > > > > > > >> The plugin has two new commits since the last
release (1
>> > bugfix
>> > > 1
>> > > > > > > >> feature) - if we want to couple version 0.2
of the plugin
>> > with a
>> > > > > > metron
>> > > > > > > >> 0.5.0 release we would need to make a 0.2
tag against HEAD
>> of
>> > > the
>> > > > > > plugin
>> > > > > > > >> repo, then increment the version in the ansible
playbooks
>> here
>> > > > > > > >> <
>> > > > > > >
>> > > > > >
>> > > > >
>> > > >
>> > >
>> >
>> https://github.com/apache/metron/blob/master/metron-deployment/ansible/roles/bro/vars/main.yml#L30
>> > > > > > > >
>> > > > > > > >> .
>> > > > > > > >>
>> > > > > > > >> Or, if we just want to make a plugin release
without
>> changing
>> > > > > > > >> apache/metron, we could just make a 0.2 tag
in the plugin
>> > repo,
>> > > > and
>> > > > > > then
>> > > > > > > >> release it in a more disjointed way.  I know
that's not
>> super
>> > > > > helpful
>> > > > > > > since
>> > > > > > > >> I don't have documentation for doing an apache
release of
>> the
>> > > > plugin
>> > > > > > > other
>> > > > > > > >> than hacking something together based on what's
out there
>> for
>> > > > > > > apache/metron.
>> > > > > > > >>
>> > > > > > > >> Reference conversations:
>> > > > > > > >>  -
>> > > > > > > >>
>> > > > > > >
>> > > > > >
>> > > > >
>> > > >
>> > >
>> >
>> https://lists.apache.org/thread.html/2606166bd5e864f1b56db302099c9a8042cdadec8fa2692fef49493f@%3Cdev.metron.apache.org%3E
>> > > > > > > >>  -
>> > > > > > > >>
>> > > > > > >
>> > > > > >
>> > > > >
>> > > >
>> > >
>> >
>> https://lists.apache.org/thread.html/3aecbadbf3353e98c03ca4b680fcd998d0cd2bf5a4319238dd85ae75@%3Cdev.metron.apache.org%3E
>> > > > > > > >>
>> > > > > > > >> Jon
>> > > > > > > >>
>> > > > > > > >> On Fri, May 25, 2018 at 2:00 PM Justin Leet
<
>> > > > justinjleet@gmail.com>
>> > > > > > > >> wrote:
>> > > > > > > >>
>> > > > > > > >>> At the risk of exposing my ignorance,
do we have the bro
>> > plugin
>> > > > > > release
>> > > > > > > >>> process documented anywhere?  We have
a doc for the main
>> > > release
>> > > > (
>> > > > > > > >>>
>> > > > https://cwiki.apache.org/confluence/display/METRON/Release+Process
>> > > > > ),
>> > > > > > > >>> but I
>> > > > > > > >>> haven't noticed one for the bro plugin.
>> > > > > > > >>>
>> > > > > > > >>> For the current RC, it's not included
and it wasn't pushed
>> > for
>> > > > (it
>> > > > > > has
>> > > > > > > >>> less
>> > > > > > > >>> changes for obvious reasons).  However,
we should be
>> making
>> > > sure
>> > > > to
>> > > > > > > >>> validate if its necessary to release and
having the
>> process
>> > > > > > documented.
>> > > > > > > >>>
>> > > > > > > >>> Justin
>> > > > > > > >>>
>> > > > > > > >> --
>> > > > > > > >>
>> > > > > > > >> Jon
>> > > > > > > >>
>> > > > > > > > --
>> > > > > > > >
>> > > > > > > > Jon
>> > > > > > > >
>> > > > > > > --
>> > > > > > >
>> > > > > > > Jon
>> > > > > > >
>> > > > > >
>> > > > >
>> > > > --
>> > > >
>> > > > Jon
>> > > >
>> > >
>> > --
>> >
>> > Jon
>> >
>>
> --
>
> Jon
>
-- 

Jon

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message