metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Miklavcic <michael.miklav...@gmail.com>
Subject Re: [DISCUSS] Mandatory relocation of Apache git repositories on git-wip-us.apache.org
Date Mon, 10 Dec 2018 23:49:23 GMT
If it's the option I'm picturing, I've used that for merging in a PR
against my PR. It's pretty simple and I don't recall it allowing options
for fitting our format. Unless I'm mistaken or that has changed, I'd
recommend our current workflow.

On Mon, Dec 10, 2018 at 3:26 PM Justin Leet <justinjleet@gmail.com> wrote:

> "merge pull request" just offers a couple ways to commit directly within
> GitHub (plain merge of all commits, squash down into one commit, and rebase
> the PR and merge it).  I don't recall it allowing you to enforce a format
> on the PRs for the commit (e.g. <PR Name> (<CONTRIBUTOR> via <COMMITTER>)
> closes apache/metron#<PR NUM>), which unfortunately makes it less than
> ideal for us, since it's prone to typos. If you don't have that
> requirement, it's great, I've used it before on other projects.
>
> If someone knows if it's possible to set it up to autobuild the appropriate
> commit message, I'd probably be for it.
>
> On Mon, Dec 10, 2018 at 5:12 PM Nick Allen <nick@nickallen.org> wrote:
>
> > Another thing to note here is that committers have admin access to the
> > Github account.  This access is granted once you link your accounts using
> > the URL that Roy sent.  It took about an hour for mine to sync.
> >
> > This means we can do things like close abandoned pull requests ourselves.
> > This also exposes the "merge pull request" button in Github.  I am not
> > quite sure how that might differ from our current 'prepare-commit'
> script.
> > I would suggest we keep using the script until we figure that out.
> >
> >
> >
> >
> > On Mon, Dec 10, 2018 at 3:29 PM Roy Lenferink <rlenferink@apache.org>
> > wrote:
> >
> > > The repo has just moved to gitbox. Keep in mind the (ASF) remote has
> > > changed. The GitHub remote remains the same.
> > > I've opened a pull request to adapt the scripts to the gitbox URLs.
> > >
> > > In order to fully use the GitBox functionality, it is needed to link
> your
> > > ASF and GitHub account which can be done here:
> > > https://gitbox.apache.org/setup/
> > >
> > > When having any questions, don't hesitate to ask!
> > >
> > > - Roy
> > >
> > > Op ma 10 dec. 2018 om 20:11 schreef Roy Lenferink <
> rlenferink@apache.org
> > >:
> > >
> > > > I have created the issue with INFRA to move over from git-wip-us to
> > > > GitBox.
> > > > METRON-1931 is created for updating the scripts with the new GitBox
> > > > location. I'll start with this once the repositories are moved.
> > > >
> > > > - Roy
> > > >
> > > > Op ma 10 dec. 2018 om 15:52 schreef Nick Allen <nick@nickallen.org>:
> > > >
> > > >> +1  Thanks for the heads up.  We will do whatever we need to to help
> > > with
> > > >> the transition.
> > > >>
> > > >> On Sun, Dec 9, 2018 at 11:03 AM Otto Fowler <
> ottobackwards@gmail.com>
> > > >> wrote:
> > > >>
> > > >>> +1
> > > >>>
> > > >>> We will need jiras and PR’s for updating our scripts post move
> > however.
> > > >>>
> > > >>
> > >
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message