metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Miklavcic <michael.miklav...@gmail.com>
Subject Re: [DISCUSS] Metron RPM spec file changelog
Date Fri, 31 May 2019 20:19:53 GMT
I'd be in favor of adding one final changelog log item that simply says
"Modifications in the changelog are now deprecated. You can find the file
change history on github here
https://github.com/apache/metron/commits/master/metron-deployment/packaging/docker/rpm-docker/SPECS/metron.spec
"

On Fri, May 31, 2019 at 1:31 PM Nick Allen <nick@nickallen.org> wrote:

> I am also in favor of not maintaining a separate change log; that is what
> git is for.  We just need to ensure that the rpmlint check can be satisfied
> in some way if we do not maintain the change log.
>
> On Fri, May 31, 2019 at 1:56 PM Ryan Merriman <merrimanr@gmail.com> wrote:
>
> > I vote we get rid of them.  It's easy enough to look through the commit
> > history to see what changed and when.  If there is a need to explain a
> > change I think an inline comment would be more appropriate.
> >
> > On Thu, May 30, 2019 at 3:52 PM Michael Miklavcic <
> > michael.miklavcic@gmail.com> wrote:
> >
> > > During a recent PR review, I discovered that we have missed updating
> the
> > > changelog for our metron.spec file many, many times -
> > >
> > >
> >
> https://github.com/apache/metron/blob/master/metron-deployment/packaging/docker/rpm-docker/SPECS/metron.spec#L728
> > >
> > > Are we getting any value out of this feature, and do we want to keep it
> > > around? It seems like it's an extra point of work, as well as potential
> > > confusion, now that we have a number of missing entries. I started
> > walking
> > > through the Git commit history and out of 81 changes, we started
> missing
> > > changes as early as the 9th change to this file. I logged a Jira
> > > https://issues.apache.org/jira/browse/METRON-2144 for addressing
> fixing
> > > the
> > > issue, but might it be better to simply jettison this feature?
> > >
> > > Mike
> > >
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message