metron-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (METRON-43) Refactor Deployment Scripts for Correctness and Ease of Use
Date Tue, 23 Feb 2016 12:35:18 GMT

    [ https://issues.apache.org/jira/browse/METRON-43?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15158796#comment-15158796
] 

ASF GitHub Bot commented on METRON-43:
--------------------------------------

Github user nickwallen commented on the pull request:

    https://github.com/apache/incubator-metron/pull/28#issuecomment-187681809
  
    Why pull all variables, even those unlikely to change, up to the inventory level?  For
example, why define `metron_jar_name` in `deployment/inventory/singlenode-vagrant/group_vars/all`?

    
    Previously these sorts of vars were pushed down into the role itself.  The logic being
that these will rarely change and that the user need not worry about them.  For example, `metron_jar_name`
is defined in `incubator-metron/deployment/roles/metron_streaming/vars/main.yml`.  



> Refactor Deployment Scripts for Correctness and Ease of Use
> -----------------------------------------------------------
>
>                 Key: METRON-43
>                 URL: https://issues.apache.org/jira/browse/METRON-43
>             Project: Metron
>          Issue Type: Improvement
>            Reporter: David M. Lyle
>            Assignee: David M. Lyle
>
> The deployment script could use a little attention. There are some ordering issues that
make them a little brittle.
> Additionally, one must enter hostnames outside of the inventory files for them to work,
this can lead to user error in provisioning.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message