metron-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jon Zeolla (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (METRON-348) bro-plugin-kafka is missing an important update
Date Mon, 25 Jul 2016 17:13:20 GMT

    [ https://issues.apache.org/jira/browse/METRON-348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15392311#comment-15392311
] 

Jon Zeolla commented on METRON-348:
-----------------------------------

Yeah I'm not worried about this from a legal/licensing perspective. My emphasis was only the
ability to include the kafka plugin in `bro/bro-plugins` as a submodule in Metron, so that
long term support was a simple as `git submodule foreach git pull origin master` (or similar)
and some testing.  Is there something that I'm missing that allows this without doing something
more manual like `git clone https://github.com/bro/bro-plugins;ls -al | grep -v kafka | xargs
rm -rf;...` or a manual process?  

> bro-plugin-kafka is missing an important update
> -----------------------------------------------
>
>                 Key: METRON-348
>                 URL: https://issues.apache.org/jira/browse/METRON-348
>             Project: Metron
>          Issue Type: Bug
>            Reporter: Jon Zeolla
>             Fix For: 0.2.1BETA
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> Metron's bro-plugin-kafka (https://github.com/apache/incubator-metron/tree/master/metron-sensors/bro-plugin-kafka)
is missing an important update (https://github.com/bro/bro-plugins/commit/b9f1f35415cb0db065348da0a5043a8353b4a0a8).
 I have opened a ticket with the bro devs in order to seek a long term resolution to this
issue (https://github.com/bro/bro-plugins/issues/31).  
> My suggestion was to have the bro team update the bro/bro-plugins repo to turn folders
(plugins) into individual branches so that they could be referenced and updated easily in
Metron and other projects as a submodule.  I was going to wait to hear back before filing
a PR, but I'm not against a short term fix of simply updating kafka/src/KafkaWriter.cc and
kafka/src/KafkaWriter.h.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message