metron-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (METRON-389) Create Java API to Read Profile Data During Model Scoring
Date Mon, 12 Sep 2016 13:16:20 GMT

    [ https://issues.apache.org/jira/browse/METRON-389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15484084#comment-15484084
] 

ASF GitHub Bot commented on METRON-389:
---------------------------------------

Github user nickwallen commented on a diff in the pull request:

    https://github.com/apache/incubator-metron/pull/236#discussion_r78369468
  
    --- Diff: metron-analytics/metron-profiler/src/main/java/org/apache/metron/profiler/bolt/ProfileBuilderBolt.java
---
    @@ -194,8 +194,8 @@ private void init(Tuple input) {
           expressions.forEach((var, expr) -> executor.assign(var, expr, message));
     
         } catch(ParseException e) {
    -      String msg = format("Bad 'init' expression: %s, profile=%s, entity=%s, start=%d",
    -              e.getMessage(), measurement.getProfileName(), measurement.getEntity(),
measurement.getStart());
    +      String msg = format("Bad 'init' expression: %s, profile=%s, entity=%s",
    +              e.getMessage(), measurement.getProfileName(), measurement.getEntity());
    --- End diff --
    
    Yes, they already are LOG.error'd inside `execute`.  
    
    The point of this catch is to add the extra note that the failure came from the 'init'
expression, rather than one of the other expressions involved in creating a profile.  I wanted
to make it blatantly obvious to the user which expression failed.


> Create Java API to Read Profile Data During Model Scoring
> ---------------------------------------------------------
>
>                 Key: METRON-389
>                 URL: https://issues.apache.org/jira/browse/METRON-389
>             Project: Metron
>          Issue Type: Improvement
>            Reporter: Nick Allen
>            Assignee: Nick Allen
>              Labels: profiler
>
> Functionality already exists to create Profiles in HBase.  A Java API is needed to read
existing Profile data from HBase.  The API should be optimized for use when scoring models.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message