metron-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (METRON-389) Create Java API to Read Profile Data During Model Scoring
Date Mon, 12 Sep 2016 13:16:20 GMT


ASF GitHub Bot commented on METRON-389:

Github user nickwallen commented on a diff in the pull request:
    --- Diff: metron-analytics/metron-profiler/src/main/java/org/apache/metron/profiler/bolt/
    @@ -194,8 +194,8 @@ private void init(Tuple input) {
           expressions.forEach((var, expr) -> executor.assign(var, expr, message));
         } catch(ParseException e) {
    -      String msg = format("Bad 'init' expression: %s, profile=%s, entity=%s, start=%d",
    -              e.getMessage(), measurement.getProfileName(), measurement.getEntity(),
    +      String msg = format("Bad 'init' expression: %s, profile=%s, entity=%s",
    +              e.getMessage(), measurement.getProfileName(), measurement.getEntity());
    --- End diff --
    Yes, they already are LOG.error'd inside `execute`.  
    The point of this catch is to add the extra note that the failure came from the 'init'
expression, rather than one of the other expressions involved in creating a profile.  I wanted
to make it blatantly obvious to the user which expression failed.

> Create Java API to Read Profile Data During Model Scoring
> ---------------------------------------------------------
>                 Key: METRON-389
>                 URL:
>             Project: Metron
>          Issue Type: Improvement
>            Reporter: Nick Allen
>            Assignee: Nick Allen
>              Labels: profiler
> Functionality already exists to create Profiles in HBase.  A Java API is needed to read
existing Profile data from HBase.  The API should be optimized for use when scoring models.

This message was sent by Atlassian JIRA

View raw message