metron-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (METRON-712) Separate evaluation from parsing in Stellar
Date Wed, 08 Mar 2017 18:59:37 GMT


ASF GitHub Bot commented on METRON-712:

Github user mmiklavc commented on the issue:
    +1 Nice addition @cestella. I didn't run the benchmarks, but I did run through the full
test plan in Vagrant quick-dev.

> Separate evaluation from parsing in Stellar
> -------------------------------------------
>                 Key: METRON-712
>                 URL:
>             Project: Metron
>          Issue Type: Improvement
>            Reporter: Casey Stella
> With the current implementation of Stellar, we cannot cache the parse tree and then apply
it after the fact. It's just an artifact of how we do the parsing: we actually execute the
statement as we parse rather than constructing an AST that can then be evaluated later given
a message. Essentially what I'm proposing is that we build the equivalent of Pattern.compile()
in Java except for Stellar.
> We should for multiple reasons:
> * code clarity - decoupling the stellar language from the generated parser code
> * performance - saving lexing and parsing for every message

This message was sent by Atlassian JIRA

View raw message