metron-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mmiklavc <...@git.apache.org>
Subject [GitHub] metron pull request #946: METRON-1465:Support for Elasticsearch X-pack
Date Mon, 02 Apr 2018 16:45:32 GMT
Github user mmiklavc commented on a diff in the pull request:

    https://github.com/apache/metron/pull/946#discussion_r178586216
  
    --- Diff: metron-interface/metron-rest/src/main/scripts/metron-rest.sh ---
    @@ -36,6 +36,7 @@ METRON_SYSCONFIG="${METRON_SYSCONFIG:-/etc/default/metron}"
     METRON_LOG_DIR="${METRON_LOG_DIR:-/var/log/metron}"
     METRON_PID_FILE="${METRON_PID_FILE:-/var/run/metron/metron-rest.pid}"
     PARSER_CONTRIB=${PARSER_CONTRIB:-$METRON_HOME/parser_contrib}
    +INDEXING_CONTRIB=${INDEXING_CONTRIB:-$METRON_HOME/indexing_contrib}
    --- End diff --
    
    @nickwallen This is consistent with what we've done for the parsers (see line 38 immediately
above). We could possibly refactor, but I wouldn't advise it as part of this PR. Not defining
a default would mean the responsibility is now on the end user for indexing, but not for parsers.
I think that is going to be more confusing to a user in the current state. I do agree that
these could probably be moved to the defaults script as a follow-on refactoring PR.


---

Mime
View raw message