metron-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (METRON-1421) Create a SolrMetaAlertDao
Date Tue, 03 Apr 2018 15:30:00 GMT

    [ https://issues.apache.org/jira/browse/METRON-1421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16424176#comment-16424176
] 

ASF GitHub Bot commented on METRON-1421:
----------------------------------------

Github user nickwallen commented on the issue:

    https://github.com/apache/metron/pull/970
  
    > @justinleet Are you more interested into breaking things out into more classes than
that, just breaking apart functions more so they're more easily tested, some combination of
both?
    
    > @justinleet Is breaking the meta alert dao into the various sub functions (Search,
Update, etc.) + pulling out the calculate logic + at least a refactoring pass for testability
a good first step in moving this forward?"
    
    Yes, I like it; that works.  I will be happy if we get better unit test coverage on all
of this. 
    



> Create a SolrMetaAlertDao
> -------------------------
>
>                 Key: METRON-1421
>                 URL: https://issues.apache.org/jira/browse/METRON-1421
>             Project: Metron
>          Issue Type: Sub-task
>            Reporter: Justin Leet
>            Assignee: Justin Leet
>            Priority: Major
>
> Create an implementation of the MetaAlertDao for Solr. This will involve implementing
the various MetaAlertDao methods using the SolrJ library and also providing a SolrMetaAlertIntegrationTest
(similar to ElasticsearchMetaAlertIntegrationTest).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message