metron-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (METRON-1465) X-pack support for Elasticsearch
Date Mon, 02 Apr 2018 16:40:04 GMT

    [ https://issues.apache.org/jira/browse/METRON-1465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16422731#comment-16422731
] 

ASF GitHub Bot commented on METRON-1465:
----------------------------------------

Github user mmiklavc commented on a diff in the pull request:

    https://github.com/apache/metron/pull/946#discussion_r178584790
  
    --- Diff: metron-platform/metron-elasticsearch/src/main/java/org/apache/metron/elasticsearch/utils/ElasticsearchUtils.java
---
    @@ -107,32 +113,94 @@ public static String getBaseIndexName(String indexName) {
         return parts[0];
       }
     
    -  public static TransportClient getClient(Map<String, Object> globalConfiguration,
Map<String, String> optionalSettings) {
    +  /**
    +   * Instantiates an Elasticsearch client based on es.client.class, if set. Defaults
to
    +   * org.elasticsearch.transport.client.PreBuiltTransportClient.
    +   *
    +   * @param globalConfiguration Metron global config
    +   * @return
    +   */
    +  public static TransportClient getClient(Map<String, Object> globalConfiguration)
{
    +    Set<String> customESSettings = new HashSet<>();
    +    customESSettings.addAll(Arrays.asList("es.client.class", "es.xpack.username", "es.xpack.password.file"));
    --- End diff --
    
    These are non-es-specific settings that we're pulling via the global config key that are
leveraged for constructing the client. The client blows up on any unexpected keys in its config.
We should probably make a note.


> X-pack support for Elasticsearch
> --------------------------------
>
>                 Key: METRON-1465
>                 URL: https://issues.apache.org/jira/browse/METRON-1465
>             Project: Metron
>          Issue Type: Bug
>    Affects Versions: 0.4.2
>            Reporter: Ward Bekker
>            Priority: Major
>             Fix For: 0.4.3
>
>
> Provide support for X-pack secured Elasticsearch clusters for the Elasticsearch writer
and the DAO used by the rest service.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message