metron-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (METRON-1507) Add support for Vagrant Cachier plugin if present
Date Thu, 05 Apr 2018 18:58:00 GMT

    [ https://issues.apache.org/jira/browse/METRON-1507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16427447#comment-16427447
] 

ASF GitHub Bot commented on METRON-1507:
----------------------------------------

Github user nickwallen commented on a diff in the pull request:

    https://github.com/apache/metron/pull/979#discussion_r179567772
  
    --- Diff: metron-deployment/ansible/roles/ambari_common/tasks/ambari-repo-centos.yml ---
    @@ -18,5 +18,13 @@
     - name: Setup Ambari repo on CentOS
       get_url: url="{{ centos_ambari_install_url }}" dest=/etc/yum.repos.d/ambari.repo
     
    +- name: Repo Cache Settings
    +  lineinfile:
    +    path: "/etc/yum.repos.d/{{ item }}"
    +    regexp: keepcache=.*
    +    line: "keepcache=1"
    +  with_fileglob:
    +    - "/etc/yum.repos.d/*.repo"
    --- End diff --
    
    What is this bit for? 
    
    When I look at the current CentOS image from master, I don't see any repo definitions
where the `keepcache` parameter is defined.  Since it is not defined, I would not expect this
`lineinfile` to do anything.
    
    ```
    [vagrant@node1 yum.repos.d]$ grep keepcache /etc/yum.repos.d/*.repo
    [vagrant@node1 yum.repos.d]$
    ```
    
    And the default setting of keepcache is already 1, AFAIK.


> Add support for Vagrant Cachier plugin if present
> -------------------------------------------------
>
>                 Key: METRON-1507
>                 URL: https://issues.apache.org/jira/browse/METRON-1507
>             Project: Metron
>          Issue Type: Improvement
>            Reporter: Simon Elliston Ball
>            Priority: Trivial
>
> Add configuration in development vagrant files to support vagrant cachier ([http://fgrehm.viewdocs.io/vagrant-cachier/)] to
reduce development machine install times. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message