metron-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From JonZeolla <...@git.apache.org>
Subject [GitHub] metron pull request #1248: METRON-1847 break out functions from prepare-comm...
Date Fri, 26 Oct 2018 18:12:36 GMT
Github user JonZeolla commented on a diff in the pull request:

    https://github.com/apache/metron/pull/1248#discussion_r228619906
  
    --- Diff: dev-utilities/committer-utils/metron-committer-common ---
    @@ -0,0 +1,353 @@
    +#!/usr/bin/env bash
    +#
    +#  Licensed to the Apache Software Foundation (ASF) under one or more
    +#  contributor license agreements.  See the NOTICE file distributed with
    +#  this work for additional information regarding copyright ownership.
    +#  The ASF licenses this file to You under the Apache License, Version 2.0
    +#  (the "License"); you may not use this file except in compliance with
    +#  the License.  You may obtain a copy of the License at
    +#
    +#      http://www.apache.org/licenses/LICENSE-2.0
    +#
    +#  Unless required by applicable law or agreed to in writing, software
    +#  distributed under the License is distributed on an "AS IS" BASIS,
    +#  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    +#  See the License for the specific language governing permissions and
    +#  limitations under the License.
    +#
    +
    +#
    +# common and unlikely to change vars
    +#
    +
    +# the upstream apache git repo for apache metron
    +METRON_UPSTREAM="https://git-wip-us.apache.org/repos/asf/metron.git"
    +# the upstream apache git repo for apache metron bro plugin kafka
    +BRO_PLUGIN_UPSTREAM="https://git-wip-us.apache.org/repos/asf/metron-bro-plugin-kafka.git"
    +# the common configuration file with the committer info
    +CONFIG_FILE=~/.metron-prepare-commit
    +
    +GITHUB_REMOTE="origin"
    +BASE_BRANCH=master
    +
    +# other var setup by these functions
    +PR=
    +WORK=
    +ORIGIN=
    +UPSTREAM=
    +PR_BRANCH=
    +USER=
    +EMAIL=
    +JIRA=
    +DESC=
    +
    +#
    +# Initialize the variables from the default configuration file, if it exists
    +#
    +function init_configuration {
    +    # does a config file already exist?
    +    echo "$CONFIG_FILE"
    +    if [ -f ${CONFIG_FILE} ]; then
    +        source ${CONFIG_FILE}
    +        echo "  ...using settings from $CONFIG_FILE"
    +    fi
    +}
    +
    +
    +#
    +# Initialize the committer variables if it is not provided through the configuration
file.
    +# If it is not present, it will be written out for the next time
    +#
    +function init_committer_info {
    +    # github account of committer (you)
    +    if [ -z "$GITHUB_NAME" ]; then
    +        read -p "  your github username [$GITHUB_NAME]: " INPUT
    +        [ -n "$INPUT" ] && GITHUB_NAME=${INPUT}
    +
    +        # write setting to config file
    +        echo "GITHUB_NAME=$GITHUB_NAME" >> ${CONFIG_FILE}
    +    fi
    +
    +    # apache id of committer (you)
    +    if [ -z "$APACHE_NAME" ]; then
    +      read -p "  your apache userid [$APACHE_NAME]: " INPUT
    +      [ -n "$INPUT" ] && APACHE_NAME=$INPUT
    +
    +      # write setting to config file
    +      echo "APACHE_NAME=$APACHE_NAME" >> ${CONFIG_FILE}
    +    fi
    +
    +    # apache email addr of committer (you)
    +    if [ -z "$APACHE_EMAIL" ]; then
    +      APACHE_EMAIL=${APACHE_NAME}@apache.org
    +      read -p "  your apache email [$APACHE_EMAIL]: " INPUT
    +      [ -n "$INPUT" ] && APACHE_EMAIL=${INPUT}
    +
    +      # write setting to config file, so it is not needed next time
    +      echo "APACHE_EMAIL=$APACHE_EMAIL" >> ${CONFIG_FILE}
    +    fi
    +}
    +
    +#
    +# Provide the user with a choice of the metron or bro repositories
    +#
    +function chose_metron_or_bro_repo {
    --- End diff --
    
    choose?


---

Mime
View raw message