metron-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (METRON-1681) Decouple the ParserBolt from the Parse execution logic
Date Tue, 02 Oct 2018 18:50:00 GMT

    [ https://issues.apache.org/jira/browse/METRON-1681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16635965#comment-16635965
] 

ASF GitHub Bot commented on METRON-1681:
----------------------------------------

Github user nickwallen commented on the issue:

    https://github.com/apache/metron/pull/1213
  
    > Before I go implementing changes we need to decide on callback vs list. I don't see
how we can design an interface that supports both (am I wrong there?) so we need to choose.
Seems to be split at the moment. Thoughts?
    
    Agreed. We should not support both.  Its one or the other.
    
    IMHO, Callbacks just seems overly complex and less obvious to me.  I could see the value
of using callbacks if this was asynchronous, but its not.  The callbacks are made synchronously
and so just returning a List seems like the most obvious approach.
    
    If callbacks more closely aligns with what was there, then just go with that.  Better
done sooner than delaying over a small nit like this.  I will assent to either.



> Decouple the ParserBolt from the Parse execution logic
> ------------------------------------------------------
>
>                 Key: METRON-1681
>                 URL: https://issues.apache.org/jira/browse/METRON-1681
>             Project: Metron
>          Issue Type: Improvement
>            Reporter: Justin Leet
>            Priority: Major
>
> Per discussion on https://github.com/apache/metron/pull/1099, there are concerns about
the ParserBolt needed some refactoring.  The discussion didn't hold the PR up, but it was
generally agreed that we should decouple some of the initialization and execution logic.
> This also aids us in integrating with other systems such as NiFi or Spark.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message