metron-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (METRON-1833) Management UI incorrectly displaying sensor topology latency units as seconds instead of millis
Date Fri, 19 Oct 2018 19:40:00 GMT


ASF GitHub Bot commented on METRON-1833:

GitHub user mmiklavc opened a pull request:

    METRON-1833: Management UI incorrectly displaying sensor topology latency units as seconds
instead of millis

    ## Contributor Comments
    Management UI is displaying units for topology latency as seconds instead of milliseconds.
This value should be identical to that reported in the Storm UI. The change is straightforward
- spin up full dev and the UI should show "ms" instead of "s"
    ## Pull Request Checklist
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at
[Metron Jira](
    - [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are
trying to resolve? Pay particular attention to the hyphen "-" character.
    - [x] Has your PR been rebased against the latest commit within the target branch (typically
    ### For code changes:
    - [x] Have you included steps to reproduce the behavior or problem that is being changed
or addressed?
    - [x] Have you included steps or a guide to how the change may be verified and tested
    - [ ] Have you ensured that the full suite of tests and checks have been executed in the
root metron folder via:
      mvn -q clean integration-test install && dev-utilities/build-utils/

    - N/A Have you written or updated unit tests and or integration tests to verify your changes?
    - N/A If adding new dependencies to the code, are these dependencies licensed in a way
that is compatible for inclusion under [ASF 2.0](
    - [ ] Have you verified the basic functionality of the build by building and running locally
with Vagrant full-dev environment or the equivalent?
    ### For documentation related changes:
    - N/A Have you ensured that format looks appropriate for the output in which it is rendered
by building and verifying the site-book? If not then run the following commands and the verify
changes via `site-book/target/site/index.html`:
      cd site-book
      mvn site
    #### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible.
    It is also recommended that [travis-ci]( is set up for your personal
repository such that your branches are built there before submitting a pull request.

You can merge this pull request into a Git repository by running:

    $ git pull ui-storm-latency

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1241
commit 4b26720e0581721470ea39198abee6bb5fa7bea6
Author: Michael Miklavcic <michael.miklavcic@...>
Date:   2018-10-19T19:34:49Z

    Fix latency measurement.


> Management UI incorrectly displaying sensor topology latency units as seconds instead
of millis
> -----------------------------------------------------------------------------------------------
>                 Key: METRON-1833
>                 URL:
>             Project: Metron
>          Issue Type: Bug
>            Reporter: Michael Miklavcic
>            Priority: Major

This message was sent by Atlassian JIRA

View raw message