metron-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (METRON-1847) Create reusable script with functions from prepare-commit
Date Fri, 26 Oct 2018 17:55:00 GMT

    [ https://issues.apache.org/jira/browse/METRON-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16665462#comment-16665462
] 

ASF GitHub Bot commented on METRON-1847:
----------------------------------------

GitHub user ottobackwards opened a pull request:

    https://github.com/apache/metron/pull/1248

    METRON-1847 break out functions from prepare-commit for re-use

    This pr breaks out the prepare-commit script into a common script and a prepare-commit
script.  This will allow re-use of that code for future scripts.
    
    Test by preparing..... commits for current PR's as is your fashion.  The script should
work as before.
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at
[Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
    - [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are
trying to resolve? Pay particular attention to the hyphen "-" character.
    - [x] Has your PR been rebased against the latest commit within the target branch (typically
master)?
    
    
    ### For code changes:
    - [-] Have you included steps to reproduce the behavior or problem that is being changed
or addressed?
    - [x] Have you included steps or a guide to how the change may be verified and tested
manually?
    - [x] Have you ensured that the full suite of tests and checks have been executed in the
root metron folder via:
      ```
      mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh

      ```
    
    - [-] Have you written or updated unit tests and or integration tests to verify your changes?
    - [-] If adding new dependencies to the code, are these dependencies licensed in a way
that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
    - [-] Have you verified the basic functionality of the build by building and running locally
with Vagrant full-dev environment or the equivalent?
    
    ### For documentation related changes:
    - [-] Have you ensured that format looks appropriate for the output in which it is rendered
by building and verifying the site-book? If not then run the following commands and the verify
changes via `site-book/target/site/index.html`:
    
      ```
      cd site-book
      mvn site
      ```
    
    #### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible.
    It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal
repository such that your branches are built there before submitting a pull request.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ottobackwards/metron script_functions

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/metron/pull/1248.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1248
    
----
commit bdc74efc5ac5b85989eb09ca76693e1e7c2cb0c4
Author: Otto Fowler <ottobackwards@...>
Date:   2018-10-26T17:51:47Z

    METRON-1847 break out functions from prepare-commit for re-use

----


> Create reusable script with functions from prepare-commit
> ---------------------------------------------------------
>
>                 Key: METRON-1847
>                 URL: https://issues.apache.org/jira/browse/METRON-1847
>             Project: Metron
>          Issue Type: Improvement
>            Reporter: Otto Fowler
>            Assignee: Otto Fowler
>            Priority: Major
>
> this will allow code reuse if and when we create more scripts



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message