metron-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mmiklavc <...@git.apache.org>
Subject [GitHub] metron pull request #1254: METRON-1849 Elasticsearch Index Write Functionali...
Date Tue, 04 Dec 2018 23:50:12 GMT
Github user mmiklavc commented on a diff in the pull request:

    https://github.com/apache/metron/pull/1254#discussion_r238883436
  
    --- Diff: metron-platform/metron-elasticsearch/src/main/java/org/apache/metron/elasticsearch/dao/ElasticsearchDao.java
---
    @@ -196,7 +196,7 @@ public ElasticsearchDao withRefreshPolicy(WriteRequest.RefreshPolicy
refreshPoli
       }
     
       protected Optional<String> getIndexName(String guid, String sensorType) throws
IOException {
    -    return updateDao.getIndexName(guid, sensorType);
    +    return updateDao.findIndexNameByGUID(guid, sensorType);
    --- End diff --
    
    Is sensorType not a component to retrieving the index name? Also, would we want any parity
between the updateDao's find method name vs the ElasticsearchDao's getIndexName method name?


---

Mime
View raw message