metron-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nickwallen <...@git.apache.org>
Subject [GitHub] metron-bro-plugin-kafka pull request #21: METRON-1911 Docker setup for testi...
Date Mon, 10 Dec 2018 13:59:40 GMT
Github user nickwallen commented on a diff in the pull request:

    https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r240208847
  
    --- Diff: docker/in_docker_scripts/build_bro_plugin.sh ---
    @@ -0,0 +1,48 @@
    +#!/usr/bin/env bash
    +
    +#
    +#  Licensed to the Apache Software Foundation (ASF) under one or more
    +#  contributor license agreements.  See the NOTICE file distributed with
    +#  this work for additional information regarding copyright ownership.
    +#  The ASF licenses this file to You under the Apache License, Version 2.0
    +#  (the "License"); you may not use this file except in compliance with
    +#  the License.  You may obtain a copy of the License at
    +#
    +#      http://www.apache.org/licenses/LICENSE-2.0
    +#
    +#  Unless required by applicable law or agreed to in writing, software
    +#  distributed under the License is distributed on an "AS IS" BASIS,
    +#  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    +#  See the License for the specific language governing permissions and
    +#  limitations under the License.
    +#
    +
    +shopt -s nocasematch
    +
    +#
    +# Runs bro-package to build and install the plugin
    +#
    +
    +cd /root/code || exit 1
    +
    +
    +make clean
    +
    +rc=$?; if [[ ${rc} != 0 ]]; then
    +  echo "ERROR cleaning project ${rc}" >>"${RUN_LOG_PATH}"
    +  exit ${rc}
    +fi
    +
    +cd /root || exit 1
    +
    +echo "================================" >>"${RUN_LOG_PATH}" 2>&1
    +bro-pkg install code --force | tee "${RUN_LOG_PATH}"
    --- End diff --
    
    Why not install the plugin in the Dockerfile?  That way an image with the plugin installed
and ready to go can be cached.


---

Mime
View raw message