metron-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (METRON-1849) Elasticsearch Index Write Functionality Should be Shared
Date Wed, 05 Dec 2018 14:32:00 GMT

    [ https://issues.apache.org/jira/browse/METRON-1849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16710129#comment-16710129
] 

ASF GitHub Bot commented on METRON-1849:
----------------------------------------

Github user nickwallen commented on a diff in the pull request:

    https://github.com/apache/metron/pull/1254#discussion_r239087246
  
    --- Diff: metron-platform/metron-elasticsearch/src/main/java/org/apache/metron/elasticsearch/bulk/BulkDocumentWriter.java
---
    @@ -0,0 +1,79 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.metron.elasticsearch.bulk;
    +
    +import org.apache.metron.indexing.dao.update.Document;
    +
    +import java.util.List;
    +
    +/**
    + * Writes documents to an index in bulk.
    + *
    + * <p>Partial failures within a batch can be handled individually by registering
    + * a {@link FailureListener}.
    + *
    + * @param <D> The type of document to write.
    + */
    +public interface BulkDocumentWriter<D extends Document> {
    +
    +    /**
    +     * A listener that is notified when a set of documents have been
    +     * written successfully.
    +     * @param <D> The type of document to write.
    +     */
    +    interface SuccessListener<D extends Document> {
    --- End diff --
    
    Yep, I think you're right.  Wish I would have noticed this before. Daft.


> Elasticsearch Index Write Functionality Should be Shared
> --------------------------------------------------------
>
>                 Key: METRON-1849
>                 URL: https://issues.apache.org/jira/browse/METRON-1849
>             Project: Metron
>          Issue Type: Bug
>            Reporter: Nick Allen
>            Assignee: Nick Allen
>            Priority: Major
>
> The index write functionality is currently duplicated between the ElasticsearchWriter
and the ElasticsearchUpdateDao.  This functionality should be de-duplicated and shared between
the two.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message