metron-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (METRON-1911) [BROS]Create Docker based test environment for Bro
Date Mon, 10 Dec 2018 15:15:00 GMT

    [ https://issues.apache.org/jira/browse/METRON-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16714889#comment-16714889
] 

ASF GitHub Bot commented on METRON-1911:
----------------------------------------

Github user ottobackwards commented on a diff in the pull request:

    https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r240249191
  
    --- Diff: docker/scripts/download_sample_pcaps.sh ---
    @@ -0,0 +1,105 @@
    +#!/usr/bin/env bash
    +
    +#
    +#  Licensed to the Apache Software Foundation (ASF) under one or more
    +#  contributor license agreements.  See the NOTICE file distributed with
    +#  this work for additional information regarding copyright ownership.
    +#  The ASF licenses this file to You under the Apache License, Version 2.0
    +#  (the "License"); you may not use this file except in compliance with
    +#  the License.  You may obtain a copy of the License at
    +#
    +#      http://www.apache.org/licenses/LICENSE-2.0
    +#
    +#  Unless required by applicable law or agreed to in writing, software
    +#  distributed under the License is distributed on an "AS IS" BASIS,
    +#  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    +#  See the License for the specific language governing permissions and
    +#  limitations under the License.
    +#
    +
    +shopt -s nocasematch
    +
    +#
    +# Downloads sample pcap files to the data directory
    +#
    +
    +function help {
    +  echo " "
    +  echo "usage: ${0}"
    +  echo "    --data-path                    [REQURIED] The pcap data path"
    +  echo "    -h/--help                      Usage information."
    +  echo " "
    +  echo " "
    +}
    +
    +DATA_PATH=
    +
    +# handle command line options
    +for i in "$@"; do
    +  case $i in
    +  #
    +  # DATA_PATH
    +  #
    +  #
    +    --data-path=*)
    +      DATA_PATH="${i#*=}"
    +      shift # past argument=value
    +    ;;
    +
    +  #
    +  # -h/--help
    +  #
    +    -h | --help)
    +      help
    +      exit 0
    +      shift # past argument with no value
    +    ;;
    +
    +  #
    +  # Unknown option
    +  #
    +    *)
    +      UNKNOWN_OPTION="${i#*=}"
    +      echo "Error: unknown option: $UNKNOWN_OPTION"
    +      help
    +    ;;
    +  esac
    +done
    +
    +if [[ -z "$DATA_PATH" ]]; then
    +  echo "DATA_PATH must be passed"
    +  exit 1
    +fi
    +
    +echo "Running download_sample_pcaps with "
    +echo "DATA_PATH = $DATA_PATH"
    +echo "==================================================="
    +
    +for folder in nitroba example-traffic ssh ftp radius rfb; do
    +  if [[ ! -d "${DATA_PATH}"/${folder} ]]; then
    +    mkdir -p "${DATA_PATH}"/${folder}
    +  fi
    +done
    +
    +if [[ ! -f "${DATA_PATH}"/example-traffic/exercise-traffic.pcap ]]; then
    +  wget https://www.bro.org/static/traces/exercise-traffic.pcap -O "${DATA_PATH}"/example-traffic/exercise-traffic.pcap
    --- End diff --
    
    I had thought of the pcaps as being external to the images, that you may have different
sets of pcaps that you want to test with, so leaving that configurable would be a good thing


> [BROS]Create Docker based test environment for Bro
> --------------------------------------------------
>
>                 Key: METRON-1911
>                 URL: https://issues.apache.org/jira/browse/METRON-1911
>             Project: Metron
>          Issue Type: New Feature
>            Reporter: Otto Fowler
>            Assignee: Otto Fowler
>            Priority: Major
>
> We would benefit from the ability to build and deploy bro, have it run against standard
pcaps and output to kafka, and capture the logs.
> Using scripts and docker, we should be able to automate this process, as it is often
written in the prs.
> These scripts could also be used in travis, with cached pcaps for regression testing.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message