metron-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (METRON-1922) Escaping incorrectly handled in current aesh version
Date Thu, 06 Dec 2018 01:33:00 GMT

    [ https://issues.apache.org/jira/browse/METRON-1922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16710854#comment-16710854
] 

ASF GitHub Bot commented on METRON-1922:
----------------------------------------

GitHub user justinleet opened a pull request:

    https://github.com/apache/metron/pull/1291

    METRON-1922: Escaping incorrectly handled in current aesh version

    ## Contributor Comments
    SPLIT('foo\\bar', '\\') doesn't work properly. It does after bumping the aesh version.
 Seems like something got fixed with the way escaping was handled.
    
    The unit test included should *theoretically* exercise this functionality, but the unit
tests directly set the buffer and bypass Console's processing of things. We can either leave
it, or I can work on getting a properly hooked up unit test to handle this.
    
    ## Pull Request Checklist
    
    Thank you for submitting a contribution to Apache Metron.  
    Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235)
for the complete guide to follow for contributions.  
    Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview)
for complete smoke testing guides.  
    
    
    In order to streamline the review of the contribution we ask you follow these guidelines
and ask you to double check the following:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at
[Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
    - [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are
trying to resolve? Pay particular attention to the hyphen "-" character.
    - [x] Has your PR been rebased against the latest commit within the target branch (typically
master)?
    
    
    ### For code changes:
    - [x] Have you included steps to reproduce the behavior or problem that is being changed
or addressed?
    - [x] Have you included steps or a guide to how the change may be verified and tested
manually?
    - [ ] Have you ensured that the full suite of tests and checks have been executed in the
root metron folder via:
      ```
      mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh

      ```
    
    - [ ] Have you written or updated unit tests and or integration tests to verify your changes?
    - [x] If adding new dependencies to the code, are these dependencies licensed in a way
that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
    - [x] Have you verified the basic functionality of the build by building and running locally
with Vagrant full-dev environment or the equivalent?
    
    ### For documentation related changes:
    - [x] Have you ensured that format looks appropriate for the output in which it is rendered
by building and verifying the site-book? If not then run the following commands and the verify
changes via `site-book/target/site/index.html`:
    
      ```
      cd site-book
      mvn site
      ```
    
    #### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible.
    It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal
repository such that your branches are built there before submitting a pull request.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/justinleet/metron aeshVersion

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/metron/pull/1291.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1291
    
----
commit c9252a3d72e04a4c394f19d08a68f488d5795c76
Author: justinjleet <justinjleet@...>
Date:   2018-12-05T21:35:34Z

    upping aesh version

----


> Escaping incorrectly handled in current aesh version
> ----------------------------------------------------
>
>                 Key: METRON-1922
>                 URL: https://issues.apache.org/jira/browse/METRON-1922
>             Project: Metron
>          Issue Type: Bug
>            Reporter: Justin Leet
>            Assignee: Justin Leet
>            Priority: Major
>
> Bump the Aesh version.
> Can be manually tested against
> {code:java}
> SPLIT('foo\\bar', '\\')
> {code}
> which will fail in the old version and succeed in the new.
> Unit testing is more of a pain, because it only occurs from interaction with Console,
but the tests pass a buffer directly.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message