metron-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sardell <>
Subject [GitHub] metron pull request #1294: METRON-1930: Update webpack-dev-server in Alerts ...
Date Mon, 10 Dec 2018 16:38:57 GMT
GitHub user sardell opened a pull request:

    METRON-1930: Update webpack-dev-server in Alerts UI

    ## Contributor Comments
    After running `npm audit` in the Alerts UI, it looks like we need to update our version
of webpack-dev-server.
    ## Testing
    Be sure your local master branch is up-to-date. From the terminal, change directories
to `metron/metron-interface/metron-alerts`. Run `npm ci`, then `npm audit`. You should see
a message notifying you of 1 vulnerability.
    To test the fix, clone this PR locally, run `npm ci`, then `npm audit`. The report should
return with 0 vulnerabilities.
    Link to vulnerability report:
    ## Pull Request Checklist
    Thank you for submitting a contribution to Apache Metron.  
    Please refer to our [Development Guidelines](
for the complete guide to follow for contributions.  
    Please refer also to our [Build Verification Guidelines](
for complete smoke testing guides.  
    In order to streamline the review of the contribution we ask you follow these guidelines
and ask you to double check the following:
    ### For all changes:
    - [ ] Is there a JIRA ticket associated with this PR? If not one needs to be created at
[Metron Jira](
    - [ ] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are
trying to resolve? Pay particular attention to the hyphen "-" character.
    - [ ] Has your PR been rebased against the latest commit within the target branch (typically
    ### For code changes:
    - [ ] Have you included steps to reproduce the behavior or problem that is being changed
or addressed?
    - [ ] Have you included steps or a guide to how the change may be verified and tested
    - [ ] Have you ensured that the full suite of tests and checks have been executed in the
root metron folder via:
      mvn -q clean integration-test install && dev-utilities/build-utils/

    - [ ] Have you written or updated unit tests and or integration tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way
that is compatible for inclusion under [ASF 2.0](
    - [ ] Have you verified the basic functionality of the build by building and running locally
with Vagrant full-dev environment or the equivalent?
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered
by building and verifying the site-book? If not then run the following commands and the verify
changes via `site-book/target/site/index.html`:
      cd site-book
      mvn site
    #### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible.
    It is also recommended that [travis-ci]( is set up for your personal
repository such that your branches are built there before submitting a pull request.

You can merge this pull request into a Git repository by running:

    $ git pull fix-npm-vulnerability

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1294
commit 3a7140b9a9fea7d384cb86aa07c740b81ca0b34b
Author: Shane Ardell <sardell@...>
Date:   2018-12-10T15:56:04Z

    update webpack-dev-server



View raw message