metron-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ottobackwards <...@git.apache.org>
Subject [GitHub] metron-bro-plugin-kafka pull request #21: METRON-1911 [WIP] Docker setup for...
Date Mon, 03 Dec 2018 20:33:59 GMT
GitHub user ottobackwards opened a pull request:

    https://github.com/apache/metron-bro-plugin-kafka/pull/21

    METRON-1911 [WIP] Docker setup for testing bro plugin

    Status>
    
    To try:
    ```
      ~/src/apache/forks/metron-bro-plugin-kafka   docker  cd docker
      ~/src/apache/forks/metron-bro-plugin-kafka/docker   docker  cp run_test.sh.template
run_test.sh
     ~/src/apache/forks/metron-bro-plugin-kafka/docker   docker  ./run_test.sh
    ```
    This will:
    
    - create a network
    - start kafka and zookeeper containers
    - create bro container ( compile bro and kafka plugin )
    - run bro container  -> drop you in a shell
    
    then in the container
    `>./built_in_scripts/run_test.sh`
    Which will build the bro plugin and test it.
    
    
    ## todo
    
    - start the bro container in the background
    - add host side scripts to docker exec 'foo'  where foo is a script in the bro container
       - execute the plugin build that way
    - configure bro for kafka
    - run script to bro -r some pcaps
    
    
    ## Pull Request Checklist
    
    Thank you for submitting a contribution to Apache Metron's Bro kafka writer plugin.
    
    In order to streamline the review of the contribution we ask you follow these guidelines
and ask you to double check the following:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at
[Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
    - [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are
trying to resolve? Pay particular attention to the hyphen "-" character.
    - [x] Has your PR been rebased against the latest commit within the target branch (typically
master)?
    
    ### For code changes:
    - [x] Have you included steps to reproduce the behavior or problem that is being changed
or addressed?
    - [x] Have you included steps or a guide to how the change may be verified and tested
manually?
    - [na] Have you ensured that the full suite of tests and checks have been executed via:
      ```
      bro-pkg test $GITHUB_USERNAME/metron-bro-plugin-kafka --version $BRANCH
      ```
    - [-] Have you written or updated unit tests and or integration tests to verify your changes?
    - [-] If adding new dependencies to the code, are these dependencies licensed in a way
that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
    - [-] Have you verified the basic functionality of the build by building and running locally
with Apache Metron's [Vagrant full-dev environment](https://github.com/apache/metron/tree/master/metron-deployment/development/centos6)
or the equivalent?


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ottobackwards/metron-bro-plugin-kafka docker

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/metron-bro-plugin-kafka/pull/21.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #21
    
----
commit f7e464c6353da3b131c3c610ba154b435a24ee95
Author: Otto Fowler <ottobackwards@...>
Date:   2018-12-03T20:23:13Z

    initial docker testing harness

----


---

Mime
View raw message