metron-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] ottobackwards commented on a change in pull request #1315: METRON-1956 add missing tests and some of the many shellcheck fixes
Date Wed, 02 Jan 2019 22:04:44 GMT
ottobackwards commented on a change in pull request #1315: METRON-1956 add missing tests and
some of the many shellcheck fixes
URL: https://github.com/apache/metron/pull/1315#discussion_r244868369
 
 

 ##########
 File path: dev-utilities/committer-utils/metron-committer-common
 ##########
 @@ -333,19 +333,125 @@ function run_tests {
     read -p "  run test suite? [yN] " -n 1 -r
     echo
     if [[ $REPLY =~ ^[Yy]$ ]]; then
-      if [ "${UPSTREAM}" == "${METRON_UPSTREAM}" ]; then
-          mvn -q -T 2C -DskipTests clean install &&
-              mvn -q -T 2C surefire:test@unit-tests &&
-              mvn -q surefire:test@integration-tests &&
-              mvn -q test --projects metron-interface/metron-config &&
-          dev-utilities/build-utils/verify_licenses.sh
-      elif [ "${UPSTREAM}" == "${BRO_PLUGIN_UPSTREAM}" ]; then
+      if [[ "${UPSTREAM}" == "${METRON_UPSTREAM}" ]]; then
+        clean_metron_src
+
+        run_mvn_install
+
+        run_mvn_unit_tests
+
+        run_mvn_integration_tests
+
+        run_mvn_ui_tests
+
+        run_mvn_build_rpms
+
+        verify_licenses
+      elif [[ "${UPSTREAM}" == "${BRO_PLUGIN_UPSTREAM}" ]]; then
         echo "We don't currently support running metron-bro-plugin-kafka tests in this script"
       fi
     fi
 
 }
 
+#
+# Cleans the metron src and rpms
+#
+function clean_metron_src {
+    echo ""
 
 Review comment:
   I don't really have a strong preference, I removed them

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message