metron-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] mmiklavc commented on issue #1317: METRON-1958: Optimize Cypress to use best practices
Date Thu, 03 Jan 2019 16:20:06 GMT
mmiklavc commented on issue #1317: METRON-1958: Optimize Cypress to use best practices
URL: https://github.com/apache/metron/pull/1317#issuecomment-451194085
 
 
   I have a post-merge comment - I really like this change:
   
   > Remove the logout click action in the afterEach hook per the Cypress team's recommendation.
While we had to do this to clean up state when the tests were run in protractor, it's unnecessary
in Cypress and can cause errors if a test is reloaded before the afterEach executes or loaded
before the page reload is complete.
   
   I've used this pattern for integration testing before and it makes repeat runs more reliable,
ie by cleaning up before the tests run, if you cancel prior to tests finishing you are still
able to re-run without worrying about old state. Also, if you run into a test failure, now
you have data post-test run that you can dig into and investigate without modifying your test
infrastructure ad-hoc.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message